Skip to content

fix(table): fix broken aria-labels for sortable columns + break out code into additional mixins + tests #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 161 commits into from
Mar 22, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Mar 20, 2019

Description of Pull Request:

Breaking the remaining bits of table into more manageable bits.

Also fixing up the sorting aria-label computation that was messed up with the introduction of sort-direction prop and field.sortDirection property (which need better documentation). It wasn't handing proper labeling of the non-sorted sortable columns (was labeling the wrong direction action 75% of the time). Adding in tests to ensure the expected labels do not get messed up (for accessibility reasons).

To Do:

  • documentation update for the above mentioned prop and field property.
  • filter testing
  • sort testing (functionality and labels / attributes)
  • pagination testing (functionality and labels/attributes)
  • additional sanity tests to make sure attributes and classes are applied correctly
  • provider testing (changing provider functions)
  • migrate from legacy testing to vue-test-utils (table styles, responsive, stacked)

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe: code re-work

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@bootstrap-vue bootstrap-vue deleted a comment from codecov-io Mar 21, 2019
@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #2884 into dev will increase coverage by 0.49%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2884      +/-   ##
==========================================
+ Coverage   90.27%   90.76%   +0.49%     
==========================================
  Files         198      201       +3     
  Lines        3249     3228      -21     
  Branches      962      969       +7     
==========================================
- Hits         2933     2930       -3     
+ Misses        229      215      -14     
+ Partials       87       83       -4
Impacted Files Coverage Δ
src/components/table/helpers/mixin-empty.js 100% <ø> (ø) ⬆️
src/components/table/helpers/mixin-thead.js 100% <100%> (+3.33%) ⬆️
src/components/table/helpers/mixin-tbody-row.js 100% <100%> (+6.33%) ⬆️
src/components/table/helpers/mixin-items.js 100% <100%> (ø)
src/components/table/helpers/mixin-filtering.js 100% <100%> (ø)
src/components/table/table.js 100% <100%> (+6.66%) ⬆️
src/components/table/helpers/mixin-pagination.js 100% <100%> (ø)
src/components/table/helpers/mixin-provider.js 100% <100%> (ø) ⬆️
src/components/table/helpers/mixin-sorting.js 100% <100%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b75dc...f9aea01. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review March 21, 2019 23:37
@tmorehouse tmorehouse requested a review from jacobmllr95 March 21, 2019 23:37
@tmorehouse tmorehouse merged commit ddc2006 into dev Mar 22, 2019
@tmorehouse tmorehouse deleted the tmorehouse/table-more branch March 22, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants