Skip to content

chore: directives code cleanup #2927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jacobmllr95
Copy link
Member

Description of Pull Request:

This PR is a overall code cleanup of the directives.

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@jacobmllr95 jacobmllr95 requested a review from tmorehouse March 27, 2019 15:03
@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #2927 into dev will increase coverage by 1.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2927      +/-   ##
==========================================
+ Coverage   91.05%   92.06%   +1.01%     
==========================================
  Files         205      205              
  Lines        3297     3253      -44     
  Branches      995      962      -33     
==========================================
- Hits         3002     2995       -7     
+ Misses        213      190      -23     
+ Partials       82       68      -14
Impacted Files Coverage Δ
src/directives/tooltip/tooltip.js 100% <100%> (+36%) ⬆️
src/directives/popover/popover.js 100% <100%> (+32%) ⬆️
src/directives/toggle/toggle.js 100% <100%> (+4.16%) ⬆️
src/directives/scrollspy/scrollspy.js 100% <100%> (ø) ⬆️
src/directives/modal/modal.js 100% <100%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e2542f...eb84260. Read the comment docs.

@tmorehouse tmorehouse changed the title feat: directives code cleanup chore: directives code cleanup Mar 27, 2019
@tmorehouse tmorehouse merged commit 4705091 into bootstrap-vue:dev Mar 27, 2019
@jacobmllr95 jacobmllr95 deleted the fix-toggle-directive-and-directives-cleanup branch March 27, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants