Skip to content

fix(env): check for undefined on process (closes #2958) #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 30, 2019
Merged

fix(env): check for undefined on process (closes #2958) #2959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f42ec02
fix(env): check for undefined on process
tmorehouse Mar 30, 2019
e0cd2c7
Update env.js
tmorehouse Mar 30, 2019
590069e
Update warn.spec.js
tmorehouse Mar 30, 2019
d67204c
Update env.js
tmorehouse Mar 30, 2019
7b14f10
Update env.js
tmorehouse Mar 30, 2019
51bbe38
Update env.js
tmorehouse Mar 30, 2019
7d993e9
lint
tmorehouse Mar 30, 2019
4038450
Update env.js
tmorehouse Mar 30, 2019
4f9f8d5
Merge branch 'dev' into tmorehouse/env
tmorehouse Mar 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/utils/env.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ export const hasPointerEvent = inBrowser && Boolean(window.PointerEvent || windo

// Getters

export const getNoWarn = () => process && process.env && process.env.BOOTSTRAP_VUE_NO_WARN
export const getNoWarn = () =>
typeof process !== 'undefined' && process && process.env && process.env.BOOTSTRAP_VUE_NO_WARN
2 changes: 1 addition & 1 deletion src/utils/warn.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('utils/warn', () => {

describe('without process object', () => {
beforeEach(() => {
global.process = null
delete global.process
})

it('calls console.warn()', () => {
Expand Down