Skip to content

chore(alert): code refactoring (closes #2967) #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Apr 1, 2019
Merged

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Mar 31, 2019

Description of Pull Request:

Revamp of <b-alert> code for simpler code logic and event emitting.

Closes #2967.

To Do:

  • additional test scenarios
  • allow show to be a number as a string

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe: code refactoring

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse changed the title Update alert.js chore(alert): code refactoring Mar 31, 2019
@jacobmllr95 jacobmllr95 changed the title chore(alert): code refactoring chore(alert): code refactoring (closes #2967) Mar 31, 2019
@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #2969 into dev will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #2969      +/-   ##
=========================================
+ Coverage   92.2%   92.23%   +0.02%     
=========================================
  Files        205      205              
  Lines       3257     3269      +12     
  Branches     962      965       +3     
=========================================
+ Hits        3003     3015      +12     
  Misses       187      187              
  Partials      67       67
Impacted Files Coverage Δ
src/components/alert/alert.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d30fafe...e9b2b06. Read the comment docs.

@jacobmllr95 jacobmllr95 marked this pull request as ready for review March 31, 2019 21:27
@tmorehouse tmorehouse requested a review from jacobmllr95 April 1, 2019 00:47
@jacobmllr95 jacobmllr95 merged commit 835bb02 into dev Apr 1, 2019
@jacobmllr95 jacobmllr95 deleted the tmorehouse/alert branch April 1, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BAlert - 'dismissed' event not emitted if 'dismissed-event-countdown' is listened
2 participants