Skip to content

feat(nuxt): add usePretranspiled option #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 8, 2019
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Apr 8, 2019

Description of Pull Request:

Introduce a new pretranspile option for for users using nuxt module.

BootstrapVue ships with pre-transpiled es/ dist. This has many advantages and does not needs transpiling again. But as it has a wider babel config (for browser support) than Nuxt, transpiling on final project produces bundles with less size and better runtime perf in flavor of more compile time.

This option by default is only enabled for production mode so we have both speed and final build quality.

Results on a starter nuxt project with BV:

usePretranspiled: true: (es/)

  • 906 KB
  • 221 KB Gzip
  • Build time: 20.51s

usePretranspiled: false: (src/)

  • 829 KB
  • 210KB Gzip
  • Build time: 27.7s

Using src/ takes more 7.2 sec and reduces bundle size for 77 KB (11 KB Gzip)

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #3048 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3048   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files         207      207           
  Lines        3742     3742           
  Branches     1123     1123           
=======================================
  Hits         3706     3706           
  Misses         28       28           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e981c2...cd03968. Read the comment docs.

@pi0 pi0 changed the title feat(nuxt): add pretranspile option feat(nuxt): add usePretranspiled option Apr 8, 2019
break long line
@tmorehouse tmorehouse requested a review from jacobmllr95 April 8, 2019 18:29
@tmorehouse tmorehouse merged commit 8022481 into dev Apr 8, 2019
@tmorehouse tmorehouse deleted the feat/nuxt-pretranspile branch April 8, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants