Skip to content

fix(b-link): ensure href prop is not passed to router-links (fixes #3066) #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 13, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Apr 11, 2019

Description of Pull Request:

Fixes #3066 (Hopefully)

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #3084 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3084      +/-   ##
==========================================
+ Coverage   99.03%   99.03%   +<.01%     
==========================================
  Files         207      207              
  Lines        3744     3746       +2     
  Branches     1123     1123              
==========================================
+ Hits         3708     3710       +2     
  Misses         28       28              
  Partials        8        8
Impacted Files Coverage Δ
src/components/dropdown/dropdown-item.js 100% <100%> (ø) ⬆️
src/components/link/link.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b758b9...c1e9209. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(b-link): ensure href prop is not passed to router-links fix(b-link): ensure href prop is not passed to router-links (fixes #3066) Apr 12, 2019
@tmorehouse tmorehouse marked this pull request as ready for review April 12, 2019 16:57
@jacobmllr95 jacobmllr95 merged commit f679c11 into dev Apr 13, 2019
@jacobmllr95 jacobmllr95 deleted the tmorehouse/link branch April 13, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<b-dropdown-item> to is going to the server instead of using vue-router
2 participants