feat(dropdown): use semantic <ul> and <li> markup (closes #3072)
#3087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3087 +/- ##
==========================================
+ Coverage 99.03% 99.03% +<.01%
==========================================
Files 207 207
Lines 3743 3744 +1
Branches 1123 1123
==========================================
+ Hits 3707 3708 +1
Misses 28 28
Partials 8 8
Continue to review full report at Codecov.
|
|
Strange.. the docs site preview isn't working right.. |
|
Ah... nav-item-dropdown needs to have its menu container updated to a UL as well. Might also have to tweak scrollspy a bit as well too... maybe |
|
|
tmorehouse
reviewed
Apr 12, 2019
tmorehouse
reviewed
Apr 12, 2019
tmorehouse
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Pull Request:
Closes #3072.
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
devbranch, not themasterbranchfixes #xxxx[,#xxxx], where "xxxx" is the issue number)and adding a new feature, break them into separate PRs if at all possible.
Conventional Commits naming convention (i.e.
"fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
"chore: fix typo in docs", etc). This is very important, as the
CHANGELOGis generatedfrom these messages.
If new features/enhancement/fixes are added or changed:
package.jsonfor slot andevent changes)
keyboard only users? clickable items should be in the tab index, etc)
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:
suggestion issue first and wait for approval before working on it)