Skip to content

feat(toast): add Bootstrap v4.3 Toasts #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 302 commits into from
Apr 17, 2019
Merged

feat(toast): add Bootstrap v4.3 Toasts #3093

merged 302 commits into from
Apr 17, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Apr 14, 2019 •
edited
Loading

Description of Pull Request:

New <b-toast> and <b-toaster> components, and Vue prototype injection $bvToast

Introduces a dependency of portal-vue: '^2.0.0'

To Do:

  • <b-toast> component
  • use portal-vue 2.0.x for transporting toasts to end of <body>
  • <b-toaster> target component for manually specifying where toasts should teleport to in the document
  • automatic <b-toaster> instantiation when b-toaster not found in document
  • $bvToast Vue prototype injection
  • Add custom toast variants
  • add root listeners for opening/closing a <b-toaster>
  • Docs page
  • toast hover auto-hide pause feature (may wait for future release)
  • Unit testing (may wait until feedback from users, as structures and usage may change)

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse self-assigned this Apr 14, 2019
@tmorehouse tmorehouse marked this pull request as ready for review April 17, 2019 05:58
@tmorehouse tmorehouse requested review from jacobmllr95 and pi0 April 17, 2019 05:59
@tmorehouse tmorehouse merged commit c31b4ff into dev Apr 17, 2019
@tmorehouse tmorehouse deleted the tmorehouse/toasts branch April 17, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobmllr95 jacobmllr95 jacobmllr95 approved these changes

@pi0 pi0 Awaiting requested review from pi0

Assignees

@tmorehouse tmorehouse

Labels
Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmorehouse @jacobmllr95