Skip to content

chore: create single point of contact module for Vue reference #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 105 commits into from
Apr 16, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Apr 16, 2019

Describe the PR

Creates a single point of contact for getting a reference to Vue

For future handing of de-duping Vue imports

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe): code refactor

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #3120 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3120   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         211      211           
  Lines        3856     3856           
  Branches     1153     1153           
=======================================
  Hits         3823     3823           
  Misses         26       26           
  Partials        7        7
Impacted Files Coverage Δ
src/components/breadcrumb/breadcrumb.js 100% <ø> (ø) ⬆️
src/components/image/img.js 100% <ø> (ø) ⬆️
src/components/form/form-valid-feedback.js 100% <ø> (ø) ⬆️
src/components/input-group/input-group-addon.js 100% <ø> (ø) ⬆️
src/components/carousel/carousel.js 100% <ø> (ø) ⬆️
src/components/button/button-close.js 100% <ø> (ø) ⬆️
src/components/dropdown/dropdown.js 100% <ø> (ø) ⬆️
src/components/jumbotron/jumbotron.js 100% <ø> (ø) ⬆️
src/components/collapse/collapse.js 100% <ø> (ø) ⬆️
...rc/components/form-checkbox/form-checkbox-group.js 100% <ø> (ø) ⬆️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4e7f21...3fa3f8b. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review April 16, 2019 20:14
@tmorehouse tmorehouse requested a review from pi0 April 16, 2019 21:12
@jacobmllr95 jacobmllr95 self-requested a review April 16, 2019 21:51
@tmorehouse tmorehouse merged commit 65242f6 into dev Apr 16, 2019
@tmorehouse tmorehouse deleted the tmorehouse/global-vue branch April 16, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants