-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(col, form-group): implement self overwriting lazy props getter (fixes: #3080) #3125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3125 +/- ##
==========================================
+ Coverage 99.14% 99.14% +<.01%
==========================================
Files 212 212
Lines 3864 3874 +10
Branches 1154 1154
==========================================
+ Hits 3831 3841 +10
Misses 26 26
Partials 7 7
Continue to review full report at Codecov.
|
jacobmllr95
approved these changes
Apr 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Vue supports components defined as factory functions, except when the component is lazy loaded (via a lazy import, or require, that return promises), as it assumes the component is either an object or a Vue.extended object (although this requirement is not documented).
This PR changes how the component is defined, switching back to the plain object format instead of a component factory function, and by replacing
props
with a self-overwriting lazy getter to generate the props on first access, and subsequently cache the results in the component's options:The first access (via
Vue.component(...)
,Vue.extend(...)
or$createElement(...)
) will generate the prop definitions and cache them.Fixes #3080
Side Note; the original issue should really be fixed in Vue (allowing a lazy loaded component to return a factory function)
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: