-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(toaster): let on-demand toasts know the toaster has been destroyed #3130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #3130 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 212 212
Lines 3860 3860
Branches 1153 1153
=======================================
Hits 3827 3827
Misses 26 26
Partials 7 7 Continue to review full report at Codecov.
|
After playing a bit with the styles and positioning, I'm starting to lean towards adding an extra wrapper div inside the But will make a separate PR for that. |
Describe the PR
Prevent toasts from re-appearing when a toaster has been destroyed and a new one with the same
name has been created. Also prevents possible memory leaks when toasters are destroyed.
Also includes updates to the toaster SCSS for better support of smaller screens
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: