Skip to content

fix(types): fix msxBoxConfirm typo #3280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2019
Merged

fix(types): fix msxBoxConfirm typo #3280

merged 1 commit into from
May 13, 2019

Conversation

Shamus03
Copy link
Contributor

@Shamus03 Shamus03 commented May 13, 2019

Describe the PR

A clear and concise description of what the pull request does.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) Types

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@Shamus03
Copy link
Contributor Author

@tmorehouse I just got a chance to update to the new rc20 version and so far this is the only issue.

@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #3280 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #3280   +/-   ##
=====================================
  Coverage   99.2%   99.2%           
=====================================
  Files        217     217           
  Lines       4156    4156           
  Branches    1193    1193           
=====================================
  Hits        4123    4123           
  Misses        26      26           
  Partials       7       7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fcc5dd...e280ba2. Read the comment docs.

@tmorehouse tmorehouse changed the title chore: fix msxBoxConfirm typo fix(types): fix msxBoxConfirm typo May 13, 2019
@tmorehouse
Copy link
Member

@Shamus03 thanks!

@tmorehouse tmorehouse merged commit 8027e5a into bootstrap-vue:dev May 13, 2019
@Shamus03 Shamus03 deleted the patch-1 branch May 13, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants