chore($bvModal): encapsulate class, etc, into the plugin installer #3305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code refactor to avoid needing to import Vue for instantiation of the on-demand MessageBox component. Adds in missing option to specify a config when Vue.use() the plugin.
Codecov Report
@@ Coverage Diff @@
## dev #3305 +/- ##
=====================================
Coverage 99.2% 99.2%
=====================================
Files 218 218
Lines 4148 4148
Branches 1197 1198 +1
=====================================
Hits 4115 4115
Misses 26 26
Partials 7 7
Continue to review full report at Codecov.
|
18 tasks
jacobmllr95
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Code refactor to avoid needing to import Vue for instantiation of the on-demand MessageBox component.
Adds in missing option to specify a config when Vue.use() the plugin.
Related to PR #3304
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch, not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples, fix typos,chore: fix typo in README, etc). This is very important, as theCHANGELOGis generated from these messages.If new features/enhancement/fixes are added or changed:
package.jsonfor slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: