Skip to content

feat(button): add new squared prop for making buttons with square corners #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 27, 2019
Merged

feat(button): add new squared prop for making buttons with square corners #3387

merged 9 commits into from
May 27, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented May 27, 2019 •
edited
Loading

Describe the PR

New squared prop will add class rounded-0 to the button to make the corners squared.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse
feat(button): add new square prop for making buttons with square co…
aa26641 
…rners


New `square` prop will add class `rounded-0` to the button to make the corners squared.
@codecov
Copy link

codecov bot commented May 27, 2019 •
edited
Loading

Codecov Report

Merging #3387 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3387   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files         219      219           
  Lines        4187     4187           
  Branches     1215     1215           
=======================================
  Hits         4155     4155           
  Misses         26       26           
  Partials        6        6
Impacted Files Coverage Δ
src/components/button/button.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a8edb...a1a8b54. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review May 27, 2019 02:11
@tmorehouse tmorehouse requested a review from jacobmllr95 May 27, 2019 02:11
@jacobmllr95
Copy link
Member

@tmorehouse Not sure if square is the right prop name.
I think it indicates too much that the button itself will get square than that the rounded corners get removed.

@tmorehouse
Copy link
Member Author

@jackmu95 maybe squared?

@tmorehouse tmorehouse changed the title feat(button): add new square prop for making buttons with square corners feat(button): add new squared prop for making buttons with square corners May 27, 2019
@tmorehouse tmorehouse merged commit 004963d into dev May 27, 2019
@tmorehouse tmorehouse deleted the tmorehouse/btn-square branch May 27, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobmllr95 jacobmllr95 jacobmllr95 approved these changes

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmorehouse @jacobmllr95