Skip to content

[ARIA] Quick fixes for breadcrumb, input-group, alert & form-fieldset #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 5, 2017
Merged

[ARIA] Quick fixes for breadcrumb, input-group, alert & form-fieldset #340

merged 12 commits into from
May 5, 2017

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented May 5, 2017

Adds ARIA features to The following components::

  • b-breadcrumb
  • b-input-group
  • b-alert
  • b-form-fieldset

Addresses parts of #333

* Create form-input-static.vue

New form-static input

* Added form-input-static compoinent

* Refactored static input

Refactored to use the new `<b-form-input-static>` component

* Switch to bFormInputStatic

Updated child component var to bFormInputStatic to follow proper naming conventions

* Removed lazyFormatter from static-input

* Added trailing semi-colon

To make CircleCI happy

* Added missing 'this'

* [nav-item] add dropdown class

* Added <slot> for robustness

* new b-form-input-static component (#292)

* Create form-input-static.vue

New form-static input

* Added form-input-static compoinent

* Refactored static input

Refactored to use the new `<b-form-input-static>` component

* Switch to bFormInputStatic

Updated child component var to bFormInputStatic to follow proper naming conventions

* Removed lazyFormatter from static-input

* Added trailing semi-colon

To make CircleCI happy

* Added missing 'this'

* Added <slot> for robustness

* fixed missing `.vue` extension on import

* Added missing extension on component import (#293)

* Optimized import order in form-input.vue (#294)

* Added missing extension on component import

* Optimized import order
Adds aria-describedby linking to label and/or feedback and/or description, Only present if an ID is provided to the fieldset

Adds new prop `labelSrOnly` which will hide label offscreen visually, but still readable by screen readers.
added aria-atomic to feedback txt
@tmorehouse tmorehouse requested a review from pi0 May 5, 2017 00:39
@pi0 pi0 merged commit 7c19bb5 into bootstrap-vue:master May 5, 2017
@tmorehouse tmorehouse deleted the tmorehouse-minor-aria branch May 6, 2017 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants