Skip to content

feat(b-tooltip, b-popover): allow global delay customization #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nfriend
Copy link
Contributor

@nfriend nfriend commented May 31, 2019

Describe the PR

Allows the show and hide delay of b-tooltip and b-popovers to be customized globally.

For example:

import Vue from 'vue';
import BVConfig from 'bootstrap-vue/es/bv-config';
import BootstrapVue from 'bootstrap-vue';

Vue.use(BVConfig, {
  BTooltip: {
    delay: {
      show: 400,
      hide: 100,
    },
  },
  BPopover: {
    delay: 1000,
  },
});

Vue.use(BootstrapVue);

These global settings apply to both the directive and component version of b-tooltip and b-popover.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #3426 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3426      +/-   ##
==========================================
+ Coverage   99.24%   99.24%   +<.01%     
==========================================
  Files         221      221              
  Lines        4211     4213       +2     
  Branches     1218     1218              
==========================================
+ Hits         4179     4181       +2     
  Misses         26       26              
  Partials        6        6
Impacted Files Coverage Δ
src/utils/config.js 100% <ø> (ø) ⬆️
src/mixins/toolpop.js 100% <ø> (ø) ⬆️
src/directives/tooltip/tooltip.js 100% <ø> (ø) ⬆️
src/directives/popover/popover.js 100% <ø> (ø) ⬆️
src/components/tooltip/tooltip.js 100% <100%> (ø) ⬆️
src/components/popover/popover.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2040b...dddc35d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #3426 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3426      +/-   ##
==========================================
+ Coverage   99.24%   99.24%   +<.01%     
==========================================
  Files         221      221              
  Lines        4211     4213       +2     
  Branches     1218     1218              
==========================================
+ Hits         4179     4181       +2     
  Misses         26       26              
  Partials        6        6
Impacted Files Coverage Δ
src/utils/config.js 100% <ø> (ø) ⬆️
src/mixins/toolpop.js 100% <ø> (ø) ⬆️
src/directives/tooltip/tooltip.js 100% <ø> (ø) ⬆️
src/directives/popover/popover.js 100% <ø> (ø) ⬆️
src/components/tooltip/tooltip.js 100% <100%> (ø) ⬆️
src/components/popover/popover.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2040b...dddc35d. Read the comment docs.

@tmorehouse tmorehouse added PR: Patch Requires patch version bump Type: Enhancement labels May 31, 2019
@tmorehouse
Copy link
Member

Thanks, we just prepared v2.0.0-rc.22 for release, so this will need to wait for the net release (which shouldn't be too far off).

@tmorehouse
Copy link
Member

tmorehouse commented May 31, 2019

@nfriend just realized you're not that far from me. I'm in Saint John, NB.

@tmorehouse
Copy link
Member

I haven't merged the changelog updates yet, so maybe I can squeeze this PR in before publishing.

@tmorehouse tmorehouse merged commit 2aaec76 into bootstrap-vue:dev May 31, 2019
@nfriend
Copy link
Contributor Author

nfriend commented May 31, 2019

@nfriend just realized your not that far from me. I'm in Saint John, NB.

@tmorehouse Nice! It's not too often that I run across others from the Maritimes 😄

@nfriend nfriend deleted the nfriend-allow-global-tooltip-delay-customization branch May 31, 2019 17:34
@tmorehouse
Copy link
Member

Version 2.0.0-rc.22 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Requires patch version bump Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants