-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(build): remove deprecated es/
build
#3604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #3604 +/- ##
=====================================
Coverage 99.3% 99.3%
=====================================
Files 233 233
Lines 4485 4485
Branches 1270 1270
=====================================
Hits 4454 4454
Misses 25 25
Partials 6 6
Continue to review full report at Codecov.
|
@tmorehouse Let's get this done first so we don't have to resolve conflicts all the time. |
@jackmu95 yeah, that was my thinking as well. The conflicts were always a pain in the behind. |
BREAKING CHANGE: removal of deprecated
es/
build directoryDescribe the PR
This PR is for the 2.0.0 stable release, to remove the deprecated
es/
buildTo do:
es/
build commandscomponents/index.js
anddirectives/index.js
fileses
entrypoint indexindex.js
filesindex.js
filessrc/index.js
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Users will no longer be able to import from the
es/
build dirs. Users should be switching to the simplified import methods introduced inv2.0.0-rc.22
. Legacy plugin names will no longer work as they were only exported fromes/
build.The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: