Skip to content

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jul 21, 2019

Describe the PR

Add note to b-form-textarea docs on auto-height implementation and it's limitations (when initially visually hidden via display: none`).

Closes #3702

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Jul 21, 2019

Codecov Report

Merging #3725 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3725   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         223      223           
  Lines        4378     4378           
  Branches     1235     1235           
=======================================
  Hits         4347     4347           
  Misses         25       25           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0616cba...8c04fe7. Read the comment docs.

@tmorehouse tmorehouse merged commit f2805aa into dev Jul 21, 2019
@tmorehouse tmorehouse deleted the issue/3716 branch July 21, 2019 23:50
@jaylittle
Copy link

Did you happen to pick the wrong issue number? This doesn't appear to have anything at all to do with issue #3716...

@tmorehouse
Copy link
Member Author

Oops.... yeah,,, wrong issue in my pasts buffer... I'll re-open and close the correct one.

@tmorehouse tmorehouse changed the title chore(docs): add implemetation note on auto-height textarea (closes #3716) chore(docs): add implemetation note on auto-height textarea (closes #3702) Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-height b-form-textarea within a b-tab does not work
2 participants