Skip to content

fix(table): better detection of active text selection during click events (closes #3757) #3763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2019
Merged

fix(table): better detection of active text selection during click events (closes #3757) #3763

merged 2 commits into from
Jul 26, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jul 26, 2019 •
edited
Loading

Describe the PR

Ignore text selection active state when selection contents are empty (or string of whitespace)

Closes #3757

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse
fix(table): better detection of text selection active
d544e5e 
Ignore when selection contents are empty
@tmorehouse tmorehouse changed the title fix(table): better detection of text selection active fix(table): better detection of text selection active (closes #3757) Jul 26, 2019
@tmorehouse tmorehouse marked this pull request as ready for review July 26, 2019 14:08
@tmorehouse tmorehouse requested a review from jacobmllr95 July 26, 2019 14:08
@codecov
Copy link

codecov bot commented Jul 26, 2019 •
edited
Loading

Codecov Report

Merging #3763 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3763   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         223      223           
  Lines        4383     4383           
  Branches     1236     1236           
=======================================
  Hits         4352     4352           
  Misses         25       25           
  Partials        6        6
Impacted Files Coverage Δ
.../components/table/helpers/text-selection-active.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57aa5b0...497f44b. Read the comment docs.

@tmorehouse tmorehouse mentioned this pull request Jul 26, 2019
Closed
@tmorehouse tmorehouse changed the title fix(table): better detection of text selection active (closes #3757) fix(table): better detection of active text selection during click events (closes #3757) Jul 26, 2019
@tmorehouse tmorehouse merged commit 1a9c688 into dev Jul 26, 2019
@tmorehouse tmorehouse deleted the tmorehouse-patch-1 branch July 26, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobmllr95 jacobmllr95 jacobmllr95 approved these changes

Assignees
No one assigned
Labels
Type: Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table Component - Row Selection - Double Click: Subsequent click after double click does not fire click event
2 participants
@tmorehouse @jacobmllr95