feat(b-table-simple): new <table> wrapper component that allows users to render their own <thead>, <tfoot>, <body>
#3799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their own `<thead>`, `<tfoot>` `<body>` Renders a table element (with optional basic styles), which renders the users content in the default slot. Provides no items, sorting, etc. Just purely styles. Requires users to place their own `<thead>`, `<tfoot>`, `<tbody>` etc in the default slot.
Codecov Report
@@ Coverage Diff @@
## dev #3799 +/- ##
==========================================
+ Coverage 99.29% 99.29% +<.01%
==========================================
Files 224 226 +2
Lines 4391 4401 +10
Branches 1244 1251 +7
==========================================
+ Hits 4360 4370 +10
Misses 25 25
Partials 6 6
Continue to review full report at Codecov.
|
<thead>, <tfoot>, <body><thead>, <tfoot>, <body>
<thead>, <tfoot>, <body><table> wrapper component that allows users to render their own <thead>, <tfoot>, <body>
tmorehouse
commented
Aug 1, 2019
tmorehouse
commented
Aug 1, 2019
jacobmllr95
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Renders a table element (with optional basic styles), which renders the users content in the default slot.
Provides no items, sorting, etc. Just purely table styles (except stacked)
Requires users to place their own
<thead>,<tfoot>,<tbody>etc in the default slot.This provides users the flexibility to create row and col spans as needed
Uses some shared code with b-table, so the extra foot print of this component is very lightweight.
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch, not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples, fix typos,chore: fix typo in README, etc). This is very important, as theCHANGELOGis generated from these messages.If new features/enhancement/fixes are added or changed:
package.jsonfor slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: