-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(table): create table child element helper components, plus new sort-null-last
and table-variant
props.
#3808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3808 +/- ##
=========================================
+ Coverage 99.29% 99.3% +<.01%
=========================================
Files 226 233 +7
Lines 4401 4433 +32
Branches 1251 1257 +6
=========================================
+ Hits 4370 4402 +32
Misses 25 25
Partials 6 6
Continue to review full report at Codecov.
|
jacobmllr95
approved these changes
Aug 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Creates table child element helper components, which will be used internally by
<b-table>
and<b-table-lite>
, and can be used directly by consumers when using<b-table-simple>
. or in the slotstop-row
,bottom-row
andthead-top
The helper components simplify handling row and cell variants, as well as providing accessible aria
role
s,scope
s, and otheraria-*
attributes.role
andscope
and somearia-*
can be overridden if the users set the attributes on the component.The child components receive injections from the parent components for feature sniffing and detection.
Generated accessibility markup is improved via automated
role
s andscope
attribute generation.Additional features:
table-variant
support, to colorize the table with one of the theme colors. This feature was available before by manually placing atable-*
orbg-*
variant class on the table root element. The newtable-variant
prop simplifies this, and automatically adjusts to which variant class prefix to use, based on the tablesdark
mode.null
/undefined
/empty-string last via the newsort-null-last
prop. By defaultnull
/undefined
/empty-string are considered less than any other value. setting this pro to true makes them appear greater than any other value. (closes Return empty values last in table sorting #3816)New child components:
b-td
- functional wrapper for private helper componentBTableCell
b-th
- functional wrapper private helper componentBTableCell
b-tr
b-thead
b-tbody
b-tfoot
To Do:
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: