Skip to content

chore(table): minor code adjustments #3890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2019
Merged

chore(table): minor code adjustments #3890

merged 2 commits into from
Aug 15, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Aug 15, 2019

Describe the PR

A few minor optimization to computations for stacked mode

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) minor code tweaks

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #3890 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3890   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files         233      233           
  Lines        4467     4467           
  Branches     1263     1262    -1     
=======================================
  Hits         4437     4437           
  Misses         24       24           
  Partials        6        6
Impacted Files Coverage Δ
src/components/table/helpers/mixin-thead.js 100% <100%> (ø) ⬆️
src/components/table/helpers/mixin-stacked.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d155ba...cef569e. Read the comment docs.

@tmorehouse tmorehouse requested a review from jacobmllr95 August 15, 2019 01:24
@tmorehouse tmorehouse marked this pull request as ready for review August 15, 2019 02:01
@tmorehouse tmorehouse merged commit 6b56a10 into dev Aug 15, 2019
@tmorehouse tmorehouse deleted the tmorehouse/table-tweak branch August 15, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants