feat(b-table): new sorting icons using SVG, plus option to place icon on left of header cell (closes #3687, #3696, #3918, #3966) #3968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on left of header cell
Codecov Report
@@ Coverage Diff @@
## dev #3968 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 238 238
Lines 4465 4465
Branches 1253 1253
=======================================
Hits 4459 4459
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
jacobmllr95
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Replaces the sort icons with SVG backgrounds
New Boolean prop
sort-icon-leftto place the icons on the left side of the header cell instead of the default of right.Closes #3687
Closes #3696
Closes #3918
Closes #3966
Removed SASS variables:
$b-table-sort-icon-null$b-table-sort-icon-ascending$b-table-sort-icon-descending$b-table-sort-icon-margin-left$b-table-sort-icon-widthNew SASS variables:
$b-table-sort-icon-bg-width$b-table-sort-icon-bg-height$b-table-sort-icon-bg-not-sorted$b-table-sort-icon-bg-descending$b-table-sort-icon-bg-ascending$b-table-sort-icon-bg-dark-not-sorted(for dark mode tables)$b-table-sort-icon-bg-dark-descending(for dark mode tables)$b-table-sort-icon-bg-dark-ascending(for dark mode tables)PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Old SCSS variables for icons (character based) have removed and replaced with SVG background icons. Users can config new icons using CSS variables (either data URI's or full URLs)
The breaking change in SCSS does not affect usability of sorting, just the customization of the sort icons
The PR fulfills these requirements:
devbranch, not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples, fix typos,chore: fix typo in README, etc). This is very important, as theCHANGELOGis generated from these messages.If new features/enhancement/fixes are added or changed:
package.jsonfor slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: