Skip to content

chore(pagination): change role="none presentation" to role="presentation" (closes #2921) #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 31, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Aug 31, 2019

Describe the PR

Clears up issues with A11Y and pagination components.

Google Lighthouse appears to be happy with just role="presentation"

Closes #2921

Note: https://www.w3.org/TR/wai-aria-practices/examples/menubar/menubar-1/menubar-1.html#
ARIA Practices 1.1 show them using role "none" on the <li> elements

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse changed the title chore(pagination): remove role="non presentation" from <li> elements chore(pagination): remove role="none presentation" from <li> elements Aug 31, 2019
@codecov
Copy link

codecov bot commented Aug 31, 2019

Codecov Report

Merging #3993 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3993   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         238      238           
  Lines        4453     4453           
  Branches     1252     1252           
=======================================
  Hits         4447     4447           
  Misses          5        5           
  Partials        1        1
Impacted Files Coverage Δ
src/mixins/pagination.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f73c7...7b8dac8. Read the comment docs.

@tmorehouse tmorehouse changed the title chore(pagination): remove role="none presentation" from <li> elements chore(pagination): change role="none presentation" to role="presentation" Aug 31, 2019
@tmorehouse tmorehouse marked this pull request as ready for review August 31, 2019 08:01
@tmorehouse tmorehouse changed the title chore(pagination): change role="none presentation" to role="presentation" chore(pagination): change role="none presentation" to role="presentation" (closes #2921) Aug 31, 2019
@tmorehouse tmorehouse requested a review from jacobmllr95 August 31, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination and Pagination Nav do not have valid accessibility roles
2 participants