Skip to content

feat(dropdown): add role=presentation to <li> elements for improved a11y #3996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 1, 2019
Merged

feat(dropdown): add role=presentation to <li> elements for improved a11y #3996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
15d174f
chore(dropdown): add `role=presentation` to `<li>` elements
tmorehouse Aug 31, 2019
304c2bc
Update dropdown-form.js
tmorehouse Aug 31, 2019
957c324
Update dropdown-group.js
tmorehouse Aug 31, 2019
5fd1db1
Update dropdown-header.js
tmorehouse Aug 31, 2019
b16b349
Update dropdown-item-button.js
tmorehouse Aug 31, 2019
d1831c8
Update dropdown-item.js
tmorehouse Aug 31, 2019
f425893
Update dropdown-text.js
tmorehouse Aug 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/dropdown/dropdown-divider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const BDropdownDivider = /*#__PURE__*/ Vue.extend({
inheritAttrs: false,
props,
render(h, { props, data }) {
return h('li', [
return h('li', { attrs: { role: 'presentation' } }, [
h(
props.tag,
mergeData(data, {
Expand Down
2 changes: 1 addition & 1 deletion src/components/dropdown/dropdown-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const BDropdownForm = /*#__PURE__*/ Vue.extend({
}
},
render(h, { props, data, children }) {
return h('li', [
return h('li', { attrs: { role: 'presentation' } }, [
h(
BForm,
mergeData(data, {
Expand Down
3 changes: 2 additions & 1 deletion src/components/dropdown/dropdown-group.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,15 @@ export const BDropdownGroup = /*#__PURE__*/ Vue.extend({
.join(' ')
.trim()

return h('li', [
return h('li', { attrs: { role: 'presentation' } }, [
header || h(),
h(
'ul',
mergeData(data, {
staticClass: 'list-unstyled',
attrs: {
id: props.id || null,
role: 'group',
'aria-describedby': adb || null
}
}),
Expand Down
2 changes: 1 addition & 1 deletion src/components/dropdown/dropdown-header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const BDropdownHeader = /*#__PURE__*/ Vue.extend({
inheritAttrs: false,
props,
render(h, { props, data, children }) {
return h('li', [
return h('li', { attrs: { role: 'presentation' } }, [
h(
props.tag,
mergeData(data, {
Expand Down
2 changes: 1 addition & 1 deletion src/components/dropdown/dropdown-item-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const BDropdownItemButton = /*#__PURE__*/ Vue.extend({
}
},
render(h) {
return h('li', [
return h('li', { attrs: { role: 'presentation' } }, [
h(
'button',
{
Expand Down
2 changes: 1 addition & 1 deletion src/components/dropdown/dropdown-item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const BDropdownItem = /*#__PURE__*/ Vue.extend({
}
},
render(h) {
return h('li', [
return h('li', { attrs: { role: 'presentation' } }, [
h(
BLink,
{
Expand Down
2 changes: 1 addition & 1 deletion src/components/dropdown/dropdown-text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const BDropdownText = /*#__PURE__*/ Vue.extend({
}
},
render(h, { props, data, children }) {
return h('li', [
return h('li', { attrs: { role: 'presentation' } }, [
h(
props.tag,
mergeData(data, {
Expand Down