fix(b-table, b-table-lite): generate :key
for row-details
row based on the primary-key
field value if available
#4025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Row details was always using the physical row index to generate the Vue render
:key
, causing any row details child components to re-render if new rows were prepended (unshift
ed) to the items array.This PR makes the details row use a
:key
based on the item's row key (based on primary key field if available). This will prevent unnecessary re-renders of components inside details slot (as long as aprimary-key
field is provided).Improves render performance when using child components in a
row-details
slot.Fixes an issue on stackoverflow:
https://stackoverflow.com/questions/57708063/b-table-reloads-nested-components-when-unshifting-a-new-row-but-not-when-pus
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: