Skip to content

chore(nuxt.config.js): update manifest to pwa.manifest #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 9, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Sep 5, 2019

Describe the PR

Update for new changes in Nuxt PWA version 3.0.0-beta.17

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #4028 into renovate/all-minor-patch will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           renovate/all-minor-patch    #4028      +/-   ##
============================================================
+ Coverage                     99.84%   99.86%   +0.02%     
============================================================
  Files                           238      238              
  Lines                          4475     4479       +4     
  Branches                       1259     1261       +2     
============================================================
+ Hits                           4468     4473       +5     
+ Misses                            6        5       -1     
  Partials                          1        1
Impacted Files Coverage Δ
src/components/tooltip/helpers/bv-tooltip.js 99.59% <0%> (-0.01%) ⬇️
src/components/modal/helpers/modal-manager.js 100% <0%> (ø) ⬆️
src/utils/transporter.js 100% <0%> (ø) ⬆️
src/components/pagination-nav/pagination-nav.js 100% <0%> (ø) ⬆️
src/components/table/helpers/mixin-provider.js 100% <0%> (ø) ⬆️
src/mixins/pagination.js 100% <0%> (ø) ⬆️
src/components/toast/toast.js 100% <0%> (ø) ⬆️
src/components/modal/modal.js 99.59% <0%> (ø) ⬆️
src/components/modal/helpers/bv-modal.js 100% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34339b7...cf5fc41. Read the comment docs.

@tmorehouse
Copy link
Member Author

tmorehouse commented Sep 6, 2019

v3.0.0-beta.17 fails at supplying icons to the manifest and favicon.

On hold until beta-18 (or later)

nuxt-community/pwa-module#231

@tmorehouse
Copy link
Member Author

Reverted the upgrade to beta.17 (downgraded back to beta.16).

Can't merge in dev since it has the revert.

@tmorehouse tmorehouse changed the base branch from dev to renovate/all-minor-patch September 9, 2019 00:05
@tmorehouse tmorehouse marked this pull request as ready for review September 9, 2019 00:12
@tmorehouse tmorehouse merged commit 622fbae into renovate/all-minor-patch Sep 9, 2019
@tmorehouse tmorehouse deleted the tmorehouse/docs-manifest branch September 9, 2019 00:13
jacobmllr95 pushed a commit that referenced this pull request Sep 9, 2019
* chore(deps): update all non-major dependencies

* Update modal.js

* Update bv-tooltip.js

* Update bv-modal.js

* Update pagination.js

* Update pagination-nav.js

* Update toast.js

* Update mixin-provider.js

* Update mixin-provider.js

* Update mixin-provider.js

* Update bv-modal.js

* chore(nuxt.config.js): update `manifest` to `pwa.manifest` (#4028)

* Update bv-modal.js

* Update bv-modal.js

* fix `eslint` dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants