[unit testing] table calls provider only once when filter is object #4067

caiquecastro · 2019-09-10T11:14:53Z

Describe the PR

A clear and concise description of what the pull request does.

PR checklist

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

No
Yes (please describe)

The PR fulfills these requirements:

It's submitted to the dev branch, not the master branch
When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

Includes documentation updates (including updating the component's package.json for slot and event changes)
Includes any needed TypeScript declaration file updates
New/updated tests are included and passing (if required)
Existing test suites are passing
The changes have not impacted the functionality of other components or directives
ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

codecov · 2019-09-10T11:21:05Z

Codecov Report

Merging #4067 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #4067   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         238      238           
  Lines        4475     4475           
  Branches     1260     1260           
=======================================
  Hits         4469     4469           
  Misses          5        5           
  Partials        1        1

Impacted Files	Coverage Δ
src/components/tooltip/helpers/bv-tooltip.js	`99.6% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eda4fe...b55d233. Read the comment docs.

tmorehouse · 2019-09-10T13:52:25Z

If prop fields is not defined, it i possible for the provider to be called twice, once to lookup the fields, and then once when populating the items.

caiquecastro · 2019-09-10T16:33:47Z

The fields are defined. I can update the tests to check it.

tmorehouse · 2019-09-10T16:42:44Z

PR #4068 may fix this issue

tmorehouse · 2019-09-10T17:08:09Z

Also note that the filter can only be an object when a filter-function is provided. The internal filter function can only handle strings or regular expressions. If anything other than a string or regular expression is passed, and a filter-function is not provided, then the filter criteria will be converted to an empty string ''.

EDIT: object is allowed when provider filtering is happening

tmorehouse · 2019-09-10T17:25:51Z

src/components/table/table-provider.spec.js

+    // the provider is being called twice
+    expect(providerCallCount).toBe(2)
+
+    filter.a = '456';


Just setting this will not update the prop in Vue Test Utils. you need to call setProps on the wrapper

wrapper.setProps({ filter: filter })

tmorehouse · 2019-09-10T17:27:10Z

src/components/table/table-provider.spec.js

+      return testItems.slice()
+    }
+
+    mount(BTable, {


When mounting, assign the return value to wrapper, so that it can be destroyed at the end of the test. otherwise it remains in the DOM during the other tests (and occupies memory space as well)

tmorehouse · 2019-09-11T01:55:27Z

Confirmed: PR #4068 fixes your original issue re provider being called twice when filter is preset before mount and items is a provider function

caiquecastro added 2 commits September 10, 2019 08:12

Calls provider only once when filter is object

2e7d2fe

Fix lint errors

a9376e8

caiquecastro added 2 commits September 10, 2019 08:26

Testing

a0d5fdf

Revert testing assertions

69ec831

caiquecastro mentioned this pull request Sep 10, 2019

b-table: filter as object not reactive anymore when using items provider #4065

Closed

caiquecastro added 3 commits September 10, 2019 08:40

Provider not called for changed filter object

77b0dd4

Add assertion

1685229

Fix assertion

7914ca9

Use fields on test

150f2dd

Merge branch 'dev' into dev

4211fe2

tmorehouse reviewed Sep 10, 2019

View reviewed changes

caiquecastro added 3 commits September 10, 2019 15:36

Prevent memory leak on tests

7815ae3

Fix test

367d4ce

Fix lint errors

e98ddc7

tmorehouse mentioned this pull request Sep 11, 2019

fix(b-table): handle filter as an object when using providers and prevent duplicate provider calls on mount (fixes #4065) #4068

Merged

19 tasks

tmorehouse changed the title ~~Calls provider only once when filter is object~~ [unit testing] Calls provider only once when filter is object Sep 11, 2019

tmorehouse added the Status: Stale label Sep 11, 2019

tmorehouse changed the title ~~[unit testing] Calls provider only once when filter is object~~ [unit testing] table calls provider only once when filter is object Sep 11, 2019

Merge branch 'dev' into dev

b55d233

jacobmllr95 added the Type: Unit Testing label Sep 11, 2019

tmorehouse closed this in #4068 Sep 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[unit testing] table calls provider only once when filter is object #4067

[unit testing] table calls provider only once when filter is object #4067

Uh oh!

caiquecastro commented Sep 10, 2019 •

edited

Loading

Uh oh!

codecov bot commented Sep 10, 2019 •

edited

Loading

Uh oh!

tmorehouse commented Sep 10, 2019

Uh oh!

caiquecastro commented Sep 10, 2019

Uh oh!

tmorehouse commented Sep 10, 2019

Uh oh!

tmorehouse commented Sep 10, 2019 •

edited

Loading

Uh oh!

tmorehouse Sep 10, 2019

Uh oh!

tmorehouse Sep 10, 2019

Uh oh!

tmorehouse commented Sep 11, 2019

Uh oh!

Uh oh!

Uh oh!

[unit testing] table calls provider only once when filter is object #4067

[unit testing] table calls provider only once when filter is object #4067

Uh oh!

Conversation

caiquecastro commented Sep 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe the PR

PR checklist

Uh oh!

codecov bot commented Sep 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tmorehouse commented Sep 10, 2019

Uh oh!

caiquecastro commented Sep 10, 2019

Uh oh!

tmorehouse commented Sep 10, 2019

Uh oh!

tmorehouse commented Sep 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmorehouse Sep 10, 2019

Choose a reason for hiding this comment

Uh oh!

tmorehouse Sep 10, 2019

Choose a reason for hiding this comment

Uh oh!

tmorehouse commented Sep 11, 2019

Uh oh!

Uh oh!

caiquecastro commented Sep 10, 2019 •

edited

Loading

codecov bot commented Sep 10, 2019 •

edited

Loading

tmorehouse commented Sep 10, 2019 •

edited

Loading