feat(b-form-input, b-form-textarea): add lazy modifier prop to update v-model on change/blur event
#4169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate v-model on change event
Codecov Report
@@ Coverage Diff @@
## dev #4169 +/- ##
==========================================
+ Coverage 99.86% 99.91% +0.04%
==========================================
Files 237 237
Lines 4544 4548 +4
Branches 1284 1280 -4
==========================================
+ Hits 4538 4544 +6
+ Misses 5 3 -2
Partials 1 1
Continue to review full report at Codecov.
|
jacobmllr95
approved these changes
Sep 30, 2019
|
@tmorehouse Our current implementation of the This is the test setup I used in the playground: <div>
<input
v-model.trim="text1"
class="form-control mb-2"
@input="onInput('text1', $event.target.value)"
@change="onChange('text1', $event.target.value)"
>
<input
v-model.trim.number="text2"
class="form-control mb-2"
@input="onInput('text2', $event.target.value)"
@change="onChange('text2', $event.target.value)"
>
<input
v-model.lazy.trim="text3"
class="form-control mb-2"
@input="onInput('text3', $event.target.value)"
@change="onChange('text3', $event.target.value)"
>
<b-form-input
v-model="text4"
class="mb-2"
@input="onInput('text4', $event)"
@change="onChange('text4', $event)"
></b-form-input>
<b-form-input
v-model="text5"
trim
lazy
@input="onInput('text5', $event)"
@change="onChange('text5', $event)"
></b-form-input>
</div>{
data() {
return {
text1: '',
text2: '',
text3: '',
text4: '',
text5: '',
}
},
methods: {
onInput(name, value) {
const localValue = this[name]
console.log('input', name, value, localValue, value === localValue)
},
onChange(name, value) {
const localValue = this[name]
console.log('change', name, value, localValue, value === localValue)
}
}
} |
tmorehouse
commented
Oct 15, 2019
lazy modifier prop to update v-model on change/blur event
jacobmllr95
approved these changes
Oct 16, 2019
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Adds a new prop
lazyto<b-form-input>and<b-form-textarea>, to only update the v-model onchange/blurevent, emulating the Vue.lazymodifierTarget release: v2.1.0
To Do:
lazypropPR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch, not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples, fix typos,chore: fix typo in README, etc). This is very important, as theCHANGELOGis generated from these messages.If new features/enhancement/fixes are added or changed:
package.jsonfor slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: