[carousel] ARIA tweaks #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should address issue #396
Coerce slide nodelist into an Array
Resync with master
Resync with master
Resync with master
Resync with master
Optimised control and indicator native tab order (by moving indicators below controls) Switched to native tabbing for indicators (rather than keyboard nav for indicators) Removed unnecessary data-slide attributes on prev/next controls Pauses animation while page is not visible (using document.hidden where supported, http://caniuse.com/#feat=pagevisibility)
33 tasks
aria-activedescendant can only be on "tabable" elements
pi0
approved these changes
May 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimised control and indicator native tab order (by moving indicators below controls)
Switched to native tabbing for indicators (rather than keyboard nav for indicators)
Removed unnecessary data-slide attributes on prev/next controls
Pauses animation while page is not visible (using document.hidden where supported, http://caniuse.com/#feat=pagevisibility)
Bonus: Reduction in code size