Skip to content

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Oct 7, 2019

Describe the PR

Two new props head-row-variant and foot-row-variant for applying a theme color variant to the head/foot built in <tr> elements

For release in v2,1.0

Closes #4215

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Two new props `head-row-variant` and `foot-row-variant` for applying a theme color variant to the head/foot built in `<tr>` elements
@tmorehouse tmorehouse added PR: Minor Requires minor version bump Status: WIP Type: Feature labels Oct 7, 2019
@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #4216 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4216      +/-   ##
==========================================
+ Coverage   99.86%   99.86%   +<.01%     
==========================================
  Files         237      237              
  Lines        4539     4544       +5     
  Branches     1281     1284       +3     
==========================================
+ Hits         4533     4538       +5     
  Misses          5        5              
  Partials        1        1
Impacted Files Coverage Δ
src/components/table/helpers/mixin-tfoot.js 100% <ø> (ø) ⬆️
src/components/table/helpers/mixin-thead.js 100% <100%> (ø) ⬆️
src/components/table/tr.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a3e6a5...3fd4469. Read the comment docs.

@tmorehouse tmorehouse changed the title feat(b-table, b-table-lite): add in head/foot row variant prop feat(b-table, b-table-lite): add in head/foot row variant prop (addresses #4215) Oct 7, 2019
@tmorehouse tmorehouse marked this pull request as ready for review October 7, 2019 20:04
@tmorehouse tmorehouse requested a review from jacobmllr95 October 7, 2019 20:05
@tmorehouse tmorehouse merged commit b222c7c into dev Oct 15, 2019
@tmorehouse tmorehouse deleted the tmorehouse/head-foot-row-variants branch October 15, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Minor Requires minor version bump Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thead-variant primary, info, ... don't work with b-table
2 participants