[table] CSS refactor #425
Merged
[table] CSS refactor #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should address issue #396
Coerce slide nodelist into an Array
Resync with master
Resync with master
Resync with master
Resync with master
When `b-table` had prop `small`, the arrows were not aligned top to bottom correctly (up to high). Also removed erroneous `.` from `table-responsive` class
pi0
reviewed
May 19, 2017
lib/components/table.vue
Outdated
| @@ -318,6 +320,29 @@ | |||
| opacity: 0.3; | |||
| } | |||
|
|
|||
| table.table-sm thead .sorting:before, | |||
There was a problem hiding this comment.
Can't we refactor it into a generalized prop selector? This is a LOT! :D
There was a problem hiding this comment.
Yeah, I was thinking the same.
Maybe making asc/desc their own class, and maybe making disabled its own class.
There was a problem hiding this comment.
so have the following classes:
sortingascdescdisabled
There was a problem hiding this comment.
I can try and refactor before the merge.
Refactored CSS to reduce footprint Removed unused CSS
|
CSS has been refactored for much smaller footprint Hopefully it should work ;-) |
|
Nice +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
b-tablehad propsmall, the arrows were not aligned top to bottom correctly (up to high).Also removed erroneous
.fromtable-responsiveclass