-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(modal, tooltips, popovers): remove no longer needed nextTick
delay when updating content in transporter portal (closes #4589)
#4604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #4604 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 251 251
Lines 5223 5223
Branches 1384 1384
=======================================
Hits 5219 5219
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
nextTick
delay when updating content in transporter portal (closes #4589)
jacobmllr95
approved these changes
Jan 13, 2020
This was referenced Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Removes the
nextTick()
delay when updating the transporter portal target content.Since all slots are now considered to be scoped slot functions, the nextTick delay is not needed to get the children v-nodes.
portal-target
has removed their nextTick delay in the updated hook (althoughvue-simple-portal
still has the delay in its updated hook).We should be able to remove some of the
await nextTick
statements in unit tests for modal, tooltips and popovers, although it is still required when testing transitionsCloses #4589
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: