Skip to content

chore(docs): mention in table docs that fixed and responsive do not work well with each other (closes #4598) #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 27, 2020

Conversation

nejinn
Copy link

@nejinn nejinn commented Jan 26, 2020

Describe the PR

Close #4598

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #4677 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4677   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         253      253           
  Lines        5267     5267           
  Branches     1401     1401           
=======================================
  Hits         5263     5263           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02d70b...246c47b. Read the comment docs.

@nejinn
Copy link
Author

nejinn commented Jan 26, 2020

I add a Responsive table notes 。 while Responsive table do not work,We can table-class="table-responsive text-nowrap"

@nejinn nejinn closed this Jan 26, 2020
@nejinn nejinn reopened this Jan 26, 2020
@nejinn nejinn requested a review from tmorehouse January 26, 2020 06:20
@tmorehouse tmorehouse changed the title Update README.md chore(docs): mention in table docs that fixed and responsive do not work well with each other (closes #4598) Jan 26, 2020
@tmorehouse tmorehouse merged commit 35a2f23 into bootstrap-vue:dev Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table responsive not work
3 participants