Skip to content

feat(b-nav-item-dropdown): add boundary prop, applicable when not in b-navbar (closes #4684) #4691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 29, 2020
Merged

feat(b-nav-item-dropdown): add boundary prop, applicable when not in b-navbar (closes #4684) #4691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
31f948b
feat(b-nav-item-dropdown): add boundary prop (used when not in b-navbar)
tmorehouse Jan 28, 2020
4692457
Update dropdown.js
tmorehouse Jan 28, 2020
bda7d4d
Update dropdown.js
tmorehouse Jan 28, 2020
7c192e2
Update package.json
tmorehouse Jan 28, 2020
e7f2a02
Merge branch 'dev' into dd-boundary
jacobmllr95 Jan 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/components/dropdown/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import Vue from '../../utils/vue'
import { arrayIncludes } from '../../utils/array'
import { stripTags } from '../../utils/html'
import { getComponentConfig } from '../../utils/config'
import { HTMLElement } from '../../utils/safe-types'
import idMixin from '../../mixins/id'
import dropdownMixin from '../../mixins/dropdown'
import normalizeSlotMixin from '../../mixins/normalize-slot'
Expand Down Expand Up @@ -72,12 +71,6 @@ export const props = {
role: {
type: String,
default: 'menu'
},
boundary: {
// String: `scrollParent`, `window` or `viewport`
// HTMLElement: HTML Element reference
type: [String, HTMLElement],
default: 'scrollParent'
}
}

Expand Down
5 changes: 5 additions & 0 deletions src/components/nav/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,11 @@
{
"prop": "noCaret",
"description": "Hide the caret indicator on the toggle button"
},
{
"prop": "boundary",
"version": "2.4.0",
"description": "The boundary constraint of the menu: 'scrollParent', 'window', 'viewport', or a reference to an HTMLElement. Has no effect when dropdown is inside a b-navbar"
}
],
"slots": [
Expand Down
7 changes: 7 additions & 0 deletions src/mixins/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { BvEvent } from '../utils/bv-event.class'
import { closest, contains, isVisible, requestAF, selectAll } from '../utils/dom'
import { hasTouchSupport } from '../utils/env'
import { isNull } from '../utils/inspect'
import { HTMLElement } from '../utils/safe-types'
import { warn } from '../utils/warn'
import clickOutMixin from './click-out'
import focusInMixin from './focus-in'
Expand Down Expand Up @@ -108,6 +109,12 @@ export default {
popperOpts: {
// type: Object,
default: () => {}
},
boundary: {
// String: `scrollParent`, `window` or `viewport`
// HTMLElement: HTML Element reference
type: [String, HTMLElement],
default: 'scrollParent'
}
},
data() {
Expand Down