-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(b-modal): add ignore-enforce-focus-selector
prop (closes #4537)
#4702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(b-modal): add ignore-enforce-focus-selector
prop (closes #4537)
#4702
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4702 +/- ##
======================================
Coverage ? 99.92%
======================================
Files ? 253
Lines ? 5269
Branches ? 1399
======================================
Hits ? 5265
Misses ? 3
Partials ? 1
Continue to review full report at Codecov.
|
…/github.com/bootstrap-vue/bootstrap-vue into feat-add-ignore-enforce-focus-selector-prop
ignoreEnforceFocusSelector
prop (closes #4537)ignore-enforce-focus-selector
prop (closes #4537)
should we include a simple (non-live) example for, say TinyMCE editor? basically mentioning the suggested value(s) when using TinyMCE? |
What about a CodeSandbox live example? |
I think just a simple mention of setting the selector to the ones for TinyMCE, rather than a full example. Basically another short paragraph under the enforce focus section of the docs. |
Describe the PR
This PR adds a new
ignore-enforce-focus-selector
prop for the<b-modal>
component.Closes #4537.
Replaces #4538.
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: