Skip to content

docs(homepage): show sponsors on homepage #4729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 6, 2020
Merged

docs(homepage): show sponsors on homepage #4729

merged 12 commits into from
Feb 6, 2020

Conversation

jacobmllr95
Copy link
Member

@jacobmllr95 jacobmllr95 commented Feb 5, 2020 •
edited
Loading

Describe the PR

This PR adds the sponsors at their different tiers on the homepage of the docs.

TODO:

  • Improve code reuse

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Feb 5, 2020 •
edited
Loading

Codecov Report

Merging #4729 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4729   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         253      253           
  Lines        5269     5269           
  Branches     1399     1399           
=======================================
  Hits         5265     5265           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865a655...bb8ffb6. Read the comment docs.

@tmorehouse tmorehouse changed the title feat(docs): show sponsors on homepage docs(homepage): show sponsors on homepage Feb 5, 2020
@tmorehouse
Copy link
Member

tmorehouse commented Feb 5, 2020 •
edited
Loading

Could we trigger the loading of the sponsors/donors/backers using the v-b-visible.once.600="callback" directive? basically load the data when the page is scrolled to at least ### pixels before the section? that way we can reduce the number of requests during page load/mount?

tmorehouse
tmorehouse reviewed Feb 5, 2020
View reviewed changes
@jacobmllr95
Copy link
Member Author

Could we trigger the loading of the sponsors/donors/backers using the v-b-visible.once.600="callback" directive? basically load the data when the page is scrolled to at least ### pixels before the section? that way we can reduce the number of requests during page load/mount?

Done. Works like a charm.

tmorehouse
tmorehouse reviewed Feb 5, 2020
View reviewed changes
@jacobmllr95 jacobmllr95 merged commit ca8d136 into dev Feb 6, 2020
@jacobmllr95 jacobmllr95 deleted the feat-docs-show-sponsors branch February 6, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmorehouse tmorehouse tmorehouse approved these changes

Assignees
No one assigned
Labels
PR: Patch Requires patch version bump Type: Docs Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobmllr95 @tmorehouse