Skip to content

chore: minor tweaks and fixes #4760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 13, 2020
Merged

chore: minor tweaks and fixes #4760

merged 14 commits into from
Feb 13, 2020

Conversation

jacobmllr95
Copy link
Member

@jacobmllr95 jacobmllr95 commented Feb 13, 2020

Describe the PR

This PR:

  • Moves the eventOn() and eventOff() utils into their own utils/events file
  • Adds a new eventOnOff() util to utilize const method = on ? eventOn : eventOff
  • Adds EVENT_OPTIONS_PASSIVE and EVENT_OPTIONS_NO_CAPTURE constants to event utils
  • Removes all unused vars and tweaks the ESLint no-unused-vars rule to detect future ones
  • Renames all occurrence of opts to options (still short enough)
  • Correct all "the" typos
  • Fixes a typo in the <b-table> docs

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) refactor

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #4760 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4760      +/-   ##
==========================================
+ Coverage   99.92%   99.92%   +<.01%     
==========================================
  Files         254      255       +1     
  Lines        5258     5276      +18     
  Branches     1396     1401       +5     
==========================================
+ Hits         5254     5272      +18     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/utils/bv-transition.js 100% <ø> (ø) ⬆️
src/components/jumbotron/jumbotron.js 100% <100%> (ø) ⬆️
src/utils/bv-hover-swap.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9651f8c...93ab639. Read the comment docs.

@jacobmllr95 jacobmllr95 merged commit 280dec8 into dev Feb 13, 2020
@jacobmllr95 jacobmllr95 deleted the chore-minor-tweaks branch February 13, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants