Skip to content

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 13, 2020

Describe the PR

properly ignore src/browser.js and src/browser-icons.js files when transpiling to the esm module build directory

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added the PR: Patch Requires patch version bump label Feb 13, 2020
@tmorehouse tmorehouse marked this pull request as ready for review February 13, 2020 21:56
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #4764 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4764   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         255      255           
  Lines        5276     5276           
  Branches     1401     1401           
=======================================
  Hits         5272     5272           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a99e6...0a5e88d. Read the comment docs.

@tmorehouse tmorehouse changed the title chore: ignore browser.js and browser-icons.js` during esm modular build chore: properly ignore browser.js and browser-icons.js` during esm modular build Feb 13, 2020
@tmorehouse tmorehouse merged commit 214168b into dev Feb 13, 2020
@tmorehouse tmorehouse deleted the esm-ignore branch February 13, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Requires patch version bump Type: Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants