Skip to content

docs(popovers, tooltips): add info about focus only trigger and cross platform behaviour #4767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 14, 2020
Merged

docs(popovers, tooltips): add info about focus only trigger and cross platform behaviour #4767

merged 9 commits into from
Feb 14, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 14, 2020 •
edited
Loading

Describe the PR

Closes #4749

To Do:

  • Popover component docs
  • Popover directive docs
  • Tooltip component docs
  • Tooltip directive docs

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Feb 14, 2020 •
edited
Loading

Codecov Report

Merging #4767 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4767   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         255      255           
  Lines        5277     5277           
  Branches     1401     1401           
=======================================
  Hits         5273     5273           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 968c957...ec17d83. Read the comment docs.

@tmorehouse
Copy link
Member Author

tmorehouse commented Feb 14, 2020 •
edited
Loading

@jackmu95 could you test the "button" in the variants section (which uses the focus trigger only) on Mac/iOS? https://deploy-preview-4767--bootstrap-vue.netlify.com/docs/components/popover#variants-and-custom-class

@jacobmllr95 jacobmllr95 self-requested a review February 14, 2020 17:22
@jacobmllr95
Copy link
Member

@tmorehouse Works :)

Bootstrap suggests to also add role="button".
Should we do that too, since <b-button> doesn't automatically adds it when in "link mode"?

@tmorehouse
Copy link
Member Author

tmorehouse commented Feb 14, 2020 •
edited
Loading

Just realized that b-button only adds the role="button" on non link/button tags, and doesn't add keydown handlers for SPACE on links when HREF === '#' (or when role is computed to be button)

We may want to tweak b-button a bit to check if the href prop is set to # (and tag is computed to be a, and if so add a keydown.space handler, and add role="button"

Similar when role is set to button on non standard tags (i.e. not <a> or <router-link> or <button>), we should add in the keydown.space handler

When role button is used, the element must respond to: click, keydown.enter (which links do), and keydown.space (which links don't normally respond to).

If href is anything other than '#' (and the rendered tag is <a>), then we wouldn't add role button or the keydown.space handler.

We can do the b-button updates in a separate PR

@jacobmllr95
Copy link
Member

@tmorehouse Fine with that.

@jacobmllr95 jacobmllr95 marked this pull request as ready for review February 14, 2020 17:39
@jacobmllr95 jacobmllr95 merged commit 97a65c2 into dev Feb 14, 2020
@jacobmllr95 jacobmllr95 deleted the issue/4749 branch February 14, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobmllr95 jacobmllr95 jacobmllr95 approved these changes

Assignees
No one assigned
Labels
Type: Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

b-popover: focus not work in firefox and safari
2 participants
@tmorehouse @jacobmllr95