Skip to content

docs: add Carbon ads #4891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Mar 6, 2020
Merged

docs: add Carbon ads #4891

merged 28 commits into from
Mar 6, 2020

Conversation

jacobmllr95
Copy link
Member

Describe the PR

A clear and concise description of what the pull request does.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@jacobmllr95 jacobmllr95 requested a review from tmorehouse March 5, 2020 22:13
@codecov
Copy link

codecov bot commented Mar 5, 2020 •
edited
Loading

Codecov Report

Merging #4891 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4891   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         269      269           
  Lines        6114     6114           
  Branches     1595     1595           
=======================================
  Hits         6110     6110           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1eb8cf...9a309e1. Read the comment docs.

@tmorehouse tmorehouse changed the title feat(docs): add Carbon ads docs: add Carbon ads Mar 5, 2020
tmorehouse
tmorehouse reviewed Mar 5, 2020
View reviewed changes
tmorehouse
tmorehouse reviewed Mar 5, 2020
View reviewed changes
@tmorehouse
Copy link
Member

Should we limit displaying the ads only on bootstrap-vue.js.org and *.netlify.com domains?

@tmorehouse

This comment has been minimized.

Sign in to view
@jacobmllr95 jacobmllr95 marked this pull request as ready for review March 6, 2020 02:30
@jacobmllr95 jacobmllr95 requested a review from tmorehouse March 6, 2020 02:30
@tmorehouse
Copy link
Member

tmorehouse commented Mar 6, 2020 •
edited
Loading

Updated the positioning of the ads a bit to be better in line with the carbonads placement requirements (specifically for mobile) https://www.carbonads.net/faq

Do you have any policies about how ads should behave on a mobile site?

The advertisement must be visible within 3x of the mobile viewport height, starting from the top of the mobile browser. An iPhone 6, with a viewport height of 375 pixels, needs to have advertisement visible within 1125 pixels from the top of the browser. The ratio is the same for both portrait and landscape views.

The general principle is that the site visitors should be able to view the ad with only one-tap scroll. Optionally, you can choose to prevent the ad from loading when viewed on mobile site.

@tmorehouse tmorehouse self-requested a review March 6, 2020 07:27
@jacobmllr95 jacobmllr95 added the PR: Patch Requires patch version bump label Mar 6, 2020
@jacobmllr95 jacobmllr95 merged commit 706926c into dev Mar 6, 2020
@jacobmllr95 jacobmllr95 deleted the feat-docs-add-carbon-ads branch March 6, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmorehouse tmorehouse tmorehouse approved these changes

Assignees
No one assigned
Labels
PR: Patch Requires patch version bump Type: Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobmllr95 @tmorehouse