Skip to content

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Mar 25, 2020

Describe the PR

Update the report issue button link in the docs to use the docs issue template

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) new issue template for docs

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #5011 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5011   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         273      273           
  Lines        6407     6407           
  Branches     1617     1617           
=======================================
  Hits         6403     6403           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0551dec...46212bf. Read the comment docs.

@tmorehouse tmorehouse added the PR: Patch Requires patch version bump label Mar 25, 2020
@tmorehouse tmorehouse changed the title chore(docs): prompt user for issue type when reporting docs issue chore(docs): use docs issue template when reporting docs issue Mar 25, 2020
@jacobmllr95 jacobmllr95 merged commit ee6fe52 into dev Mar 25, 2020
@jacobmllr95 jacobmllr95 deleted the docs-prompt branch March 25, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Requires patch version bump Type: Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants