-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(b-sidebar): new custom component <b-sidebar>
(closes #3324, #3210, #1702)
#5021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5021 +/- ##
==========================================
+ Coverage 99.93% 99.93% +<.01%
==========================================
Files 275 277 +2
Lines 6423 6509 +86
Branches 1620 1639 +19
==========================================
+ Hits 6419 6505 +86
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
is this already implemented ? i am looking for a sidebar offcanvas menu in bootstrap-vue. Thanks |
@jensgeffken it has been available since BootstrapVue v2.10.0 |
Is bootstrap-vue breaking from feature parity Bootstrap, or will this sidebar be updated to use the offcanvas component from Bootstrap 5 (if it is merged)? |
@bbugh It will be updated to match Bootstrap v5's Offcanvas component in the future. |
does anyone knows how many breaking changes are coming. in bootstrap 5 ??? 😟 |
Describe the PR
New
<b-sidebar>
component, for creating fixed viewport (left or right) slide out drawers.Users can place any arbitrary content they wish in the sidebars.
Very basic component, that leaves the majority of styling and content layout up to the user.
Roughly based on the Bootstrap
offcanvas
example.Closes #3324
Closes #3210
Closes #1702
To Do:
footer
slotlazy
prop docslazy
content renderingclose on clickout/focusout? (opt-in or out ? as it may close on things like interactive popovers)leaving out for now.add docs page for(make a separate PR)v-b-toggle
directivePR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: