-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(b-avatar): if img src
fails to load, then show icon, text or fallback icon
#5079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #5079 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 277 277
Lines 6498 6505 +7
Branches 1609 1611 +2
=======================================
+ Hits 6495 6502 +7
Misses 3 3
Continue to review full report at Codecov.
|
jacobmllr95
approved these changes
Apr 3, 2020
Merged
src
fails to load, show icon or text or fallback icon src
fails to load, then show icon, text or fallback icon
jacobmllr95
approved these changes
Apr 6, 2020
This was referenced Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
When an img
src
is given, and it fails to load, allow fallback to icon, text or default icon (in that order).Also emits
img-error
event if img src fails to load.Adds tests for
click
andimg-error
eventsPR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
src
prop now takes precedence overicon
propThe PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: