Skip to content

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Apr 6, 2020

Describe the PR

When provided a router-tag of anything other than 'a' or 'area', do not render the rel or target attributes

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) for better W3C validation

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added Status: WIP Type: Fix PR: Patch Requires patch version bump labels Apr 6, 2020
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #5107 into dev will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5107   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         277      277           
  Lines        6498     6498           
  Branches     1609     1609           
=======================================
  Hits         6495     6495           
  Misses          3        3           
Impacted Files Coverage Δ
src/components/link/link.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 404d6e8...4007b5b. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review April 6, 2020 17:13
@tmorehouse tmorehouse requested a review from jacobmllr95 April 6, 2020 17:31
@tmorehouse tmorehouse changed the title fix(b-link): don't render target or rel attrs when routerTag other than a or area provided fix(b-link): don't render target or rel attrs when router-tag other than a or area provided Apr 6, 2020
@tmorehouse tmorehouse mentioned this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Requires patch version bump Type: Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants