[collapse] Add Accordion support, ARIA, and test suite #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should address issue #396
Coerce slide nodelist into an Array
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Adds support for accordion by adding a new accordion prop that identifies a group of collapses. When the collapse in the accordion group is shown, it emits an `accordion::toggle` event on $root to signal other collapses in this accordion group to close.
Adds ARIA support to directive v-b-toggle
33 tasks
Handle transition time
|
Does this implementation of an Accordion support nested items? Can I create an Accordion within |
|
Is this fiddle covers your question? |
|
You're the man! |
|
Second example was not saved... Now all ok. And with next release BV will allow to use v-b-toggle directive on any element at page, even if it hasn't Vue instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Accordion support to
b-collapse.Collapses can be turned into an accordion by setting the prop
accordionon the collapse components to a common group identifier name. Uses eventaccordion::toggleemitted on $root to signal other collapses in the group to closeAdds ARIA compliance support to directive
v-b-toggleAddresses issue #513
Includes updated documentation and a test suite
Working example: https://jsfiddle.net/ya15m7dv/