-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(b-form-rating): add show-value-max
prop to show possible max rating when show-value
is true
#5200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ating when `show-value` is `true`
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/bootstrap-vue/bootstrap-vue/b7mt5uyxa |
Codecov Report
@@ Coverage Diff @@
## dev #5200 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 279 279
Lines 8697 8704 +7
Branches 2486 2489 +3
=========================================
+ Hits 8697 8704 +7
Continue to review full report at Codecov.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 280d1d6:
|
show-max-value
prop to show possible max rating when show-value
is true
show-value-max
prop to show possible max rating when show-value
is true
Describe the PR
When
show-value
istrue
, optionally show thex/stars
rating value when new propshow-value-max
istrue
To Do:
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: