Skip to content

chore: overwrite Vercel now default headers #5249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 26, 2020
Merged

chore: overwrite Vercel now default headers #5249

merged 8 commits into from
Apr 26, 2020

Conversation

jacobmllr95
Copy link
Member

Describe the PR

This PR overwrite the default X-Robots-Tag: noindex header for Vercel now deployments.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@jacobmllr95 jacobmllr95 requested a review from tmorehouse April 24, 2020 14:51
@vercel
Copy link

vercel bot commented Apr 24, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/ro59ujnj8
✅ Preview: https://bootstrap-vue-git-fix-now-headers.bootstrap-vue.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 24, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 15f2b64:

Sandbox Source
nervous-frost-ei6u9 Configuration

@codecov
Copy link

codecov bot commented Apr 24, 2020 •
edited
Loading

Codecov Report

Merging #5249 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5249   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          279       279           
  Lines         8705      8705           
  Branches      2489      2489           
=========================================
  Hits          8705      8705
Flag Coverage Δ
#unittests 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a366baa...15f2b64. Read the comment docs.

tmorehouse
tmorehouse approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@tmorehouse tmorehouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not that this is temporary until vercel makes the changes to their dashboards

tmorehouse
tmorehouse reviewed Apr 24, 2020
View reviewed changes
@vercel vercel bot temporarily deployed to Preview April 26, 2020 07:39 Inactive
@vercel vercel bot temporarily deployed to Preview April 26, 2020 07:40 Inactive
@tmorehouse tmorehouse merged commit 6f84fb9 into dev Apr 26, 2020
@tmorehouse tmorehouse deleted the fix-now-headers branch April 26, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmorehouse tmorehouse tmorehouse approved these changes

Assignees
No one assigned
Labels
Type: Docs Type: Temporary Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobmllr95 @tmorehouse