Skip to content

Conversation

jacobmllr95
Copy link
Member

@jacobmllr95 jacobmllr95 commented May 6, 2020

Describe the PR

This PR bumps @vue/test-utils to v1.0.0 and makes the required changes to the tests to make the work with the stable release.

TODO:

  • Always destroy the Vue wrapper instance (wrapper.destroy())
  • Decide on what to do with deprecated .isVueInstance()
  • Remove deprecated attachToDocument option usage
  • Migrate .is() to wrapper.element.tagName or wrapper.element.matches(...) (and wrapperArray.wrappers.every(wrapper => wrapper.element.matches(...)))

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@vercel
Copy link

vercel bot commented May 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/jt8g6now7
✅ Preview: https://bootstrap-vue-git-feat-vue-test-utils-v1.bootstrap-vue.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit da40ff8:

Sandbox Source
dreamy-hamilton-yoynz Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8958a37:

Sandbox Source
friendly-darwin-lrtoe Configuration

@vercel vercel bot temporarily deployed to Preview May 6, 2020 10:55 Inactive
@jacobmllr95 jacobmllr95 changed the title chore: use @vue/test-utils v1.0.0 chore: use @vue/test-utils v1.0 May 6, 2020
@vercel vercel bot temporarily deployed to Preview May 8, 2020 07:11 Inactive
@vercel vercel bot temporarily deployed to Preview May 8, 2020 07:16 Inactive
@vercel vercel bot temporarily deployed to Preview May 8, 2020 07:19 Inactive
@vercel vercel bot temporarily deployed to Preview May 8, 2020 07:28 Inactive
@vercel vercel bot temporarily deployed to Preview May 8, 2020 07:32 Inactive
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #5310 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5310   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files         283      283           
  Lines        8823     8823           
  Branches     2541     2541           
=======================================
  Hits         8803     8803           
  Misses         18       18           
  Partials        2        2           
Flag Coverage Δ
#unittests 99.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8958a37...8958a37. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview May 8, 2020 07:48 Inactive
@tmorehouse tmorehouse added PR: Patch Requires patch version bump and removed Status: WIP labels May 8, 2020
@jacobmllr95 jacobmllr95 marked this pull request as ready for review May 8, 2020 08:18
@jacobmllr95 jacobmllr95 merged commit cfc85af into dev May 8, 2020
@jacobmllr95 jacobmllr95 deleted the feat-vue-test-utils-v1 branch May 8, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Requires patch version bump Type: Unit Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants