Skip to content

fix(b-pagination-nav) don't set aria-posinset and aria-setsize attributes for page links (closes #5449) #5754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2020
Merged

fix(b-pagination-nav) don't set aria-posinset and aria-setsize attributes for page links (closes #5449) #5754

merged 2 commits into from
Sep 10, 2020

Conversation

jacobmllr95
Copy link
Member

Describe the PR

This PR makes sure to don't set aria-posinset and aria-setsize attributes for <b-pagination-nav> page links.
This is a follow-up changes to the accessibility improvements made in #4810.

Closes #5449.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@jacobmllr95 jacobmllr95 requested a review from Hiws September 9, 2020 23:26
@vercel
Copy link

vercel bot commented Sep 9, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/21wd8anc8
✅ Preview: https://bootstrap-vue-git-fix-b-pagination-nav-page-button-a11y.bootstrap-vue.vercel.app

@jacobmllr95
Copy link
Member Author

@shadow81627 @SatoshiRoppongi Can you please confirm that the A11Y issues are resolved in the deployment preview:
https://bootstrap-vue-git-fix-b-pagination-nav-page-button-a11y.bootstrap-vue.vercel.app/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 9, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8000abc:

Sandbox Source
BootstrapVue Starter Project Configuration

@codecov
Copy link

codecov bot commented Sep 9, 2020 •
edited
Loading

Codecov Report

Merging #5754 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5754   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          284       284           
  Lines         9569      9571    +2     
  Branches      2525      2527    +2     
=========================================
+ Hits          9569      9571    +2
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mixins/pagination.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f603d69...8000abc. Read the comment docs.

@shadow81627
Copy link

it looks like it is resolved. I ran a lighthouse audit on these two pages
https://bootstrap-vue-git-fix-b-pagination-nav-page-button-a11y.bootstrap-vue.vercel.app/docs/components/pagination-nav#pagination-navigation
and
https://bootstrap-vue.org/docs/components/pagination-nav#pagination-navigation

The [aria-*] attributes do not match their roles issue seems to be fixed in the release.

You guys should look at using lighthouse ci to test these issues: https://web.dev/lighthouse-ci/

@jacobmllr95 jacobmllr95 merged commit 2f7d3c8 into dev Sep 10, 2020
@jacobmllr95 jacobmllr95 deleted the fix-b-pagination-nav-page-button-a11y branch September 10, 2020 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiws Hiws Awaiting requested review from Hiws

Assignees
No one assigned
Labels
PR: Patch Requires patch version bump Type: Accessibility Type: Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pagination-nav <a> [aria-*] attributes do not match their roles
2 participants
@jacobmllr95 @shadow81627